-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(lambda-nodejs): unescaped whitespace in props.bundling.inject b…
…reaks esbuild (#29561) ### Issue # (if applicable) Closes #29559 . ### Reason for this change NodejsFunction fails to build in projects with spaces in path ### Description of changes Updated how it maps esbuild arguments from bundling props ### Description of how you validated changes Tried building the NodejsFunction ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
Showing
11 changed files
with
443 additions
and
185 deletions.
There are no files selected for viewing
42 changes: 42 additions & 0 deletions
42
....snapshot/asset.ff5094dcce664452d1dae905962ca26807cc309e15cee9e168a256ad019ef379/index.js
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
19 changes: 16 additions & 3 deletions
19
...est/aws-lambda-nodejs/test/integ.function.js.snapshot/cdk-integ-lambda-nodejs.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...dk-testing/framework-integ/test/aws-lambda-nodejs/test/integ.function.js.snapshot/cdk.out
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
...testing/framework-integ/test/aws-lambda-nodejs/test/integ.function.js.snapshot/integ.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
16 changes: 14 additions & 2 deletions
16
...ting/framework-integ/test/aws-lambda-nodejs/test/integ.function.js.snapshot/manifest.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.