Skip to content

Commit

Permalink
Merge branch 'main' into python_custom_resource_update
Browse files Browse the repository at this point in the history
  • Loading branch information
mergify[bot] authored Sep 4, 2024
2 parents 1c04bb7 + 125ca2f commit 6f1ec4e
Show file tree
Hide file tree
Showing 34 changed files with 248 additions and 44 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2190,3 +2190,13 @@ async function listChildren(parent: string, pred: (x: string) => Promise<boolean
async function listChildDirs(parent: string) {
return listChildren(parent, async (fullPath: string) => (await fs.stat(fullPath)).isDirectory());
}

integTest(
'cdk notices with --unacknowledged',
withDefaultFixture(async (fixture) => {
const noticesUnacknowledged = await fixture.cdk(['notices', '--unacknowledged'], { verbose: false });
const noticesUnacknowledgedAlias = await fixture.cdk(['notices', '-u'], { verbose: false });
expect(noticesUnacknowledged).toEqual(expect.stringMatching(/There are \d{1,} unacknowledged notice\(s\)./));
expect(noticesUnacknowledged).toEqual(noticesUnacknowledgedAlias);
}),
);

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,9 @@
"ca-central-1": {
"FirehoseCidrBlock": "35.183.92.128/27"
},
"ca-west-1": {
"FirehoseCidrBlock": "40.176.98.192/27"
},
"cn-north-1": {
"FirehoseCidrBlock": "52.81.151.32/27"
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,9 @@
"ca-central-1": {
"FirehoseCidrBlock": "35.183.92.128/27"
},
"ca-west-1": {
"FirehoseCidrBlock": "40.176.98.192/27"
},
"cn-north-1": {
"FirehoseCidrBlock": "52.81.151.32/27"
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,9 @@
"ca-central-1": {
"FirehoseCidrBlock": "35.183.92.128/27"
},
"ca-west-1": {
"FirehoseCidrBlock": "40.176.98.192/27"
},
"cn-north-1": {
"FirehoseCidrBlock": "52.81.151.32/27"
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,9 @@
"ca-central-1": {
"FirehoseCidrBlock": "35.183.92.128/27"
},
"ca-west-1": {
"FirehoseCidrBlock": "40.176.98.192/27"
},
"cn-north-1": {
"FirehoseCidrBlock": "52.81.151.32/27"
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,9 @@
"ca-central-1": {
"FirehoseCidrBlock": "35.183.92.128/27"
},
"ca-west-1": {
"FirehoseCidrBlock": "40.176.98.192/27"
},
"cn-north-1": {
"FirehoseCidrBlock": "52.81.151.32/27"
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -1024,6 +1024,7 @@ export const FIREHOSE_CIDR_BLOCKS: { [region: string]: string } = {
'ap-southeast-3': '108.136.221.64',
'ap-southeast-4': '16.50.161.128',
'ca-central-1': '35.183.92.128',
'ca-west-1': '40.176.98.192',
'cn-north-1': '52.81.151.32',
'cn-northwest-1': '161.189.23.64',
'eu-central-1': '35.158.127.160',
Expand Down
25 changes: 25 additions & 0 deletions packages/aws-cdk/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -963,6 +963,31 @@ NOTICES
If you don’t want to see a notice anymore, use "cdk acknowledge <id>". For example, "cdk acknowledge 16603".
```

List the unacknowledged notices:

```console
$ cdk notices --unacknowledged

NOTICES (What's this? https://github.com/aws/aws-cdk/wiki/CLI-Notices)

29483 (cli): Upgrading to v2.132.0 or v2.132.1 breaks cdk diff functionality

Overview: cdk diff functionality used to rely on assuming lookup-role.
With a recent change present in v2.132.0 and v2.132.1, it is
now trying to assume deploy-role with the lookup-role. This
leads to an authorization error if permissions were not
defined to assume deploy-role.

Affected versions: cli: >=2.132.0 <=2.132.1

More information at: https://github.com/aws/aws-cdk/issues/29483


If you don’t want to see a notice anymore, use "cdk acknowledge <id>". For example, "cdk acknowledge 29483".

There are 1 unacknowledged notice(s).
```

### Bundling

By default asset bundling is skipped for `cdk list` and `cdk destroy`. For `cdk deploy`, `cdk diff`
Expand Down
Loading

0 comments on commit 6f1ec4e

Please sign in to comment.