Skip to content

Commit

Permalink
Update default value for customHeaders
Browse files Browse the repository at this point in the history
  • Loading branch information
georeeve committed Oct 22, 2024
1 parent 0260046 commit 5af460d
Show file tree
Hide file tree
Showing 29 changed files with 55 additions and 42 deletions.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-amplify-alpha/lib/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export class App extends Resource implements IApp, iam.IGrantable {
name: props.appName || this.node.id,
oauthToken: sourceCodeProviderOptions?.oauthToken?.unsafeUnwrap(), // Safe usage
repository: sourceCodeProviderOptions?.repository,
customHeaders: props.customResponseHeaders ? renderCustomResponseHeaders(props.customResponseHeaders) : undefined,
customHeaders: props.customResponseHeaders ? renderCustomResponseHeaders(props.customResponseHeaders) : '',
platform: props.platform || Platform.WEB,
});

Expand Down
1 change: 1 addition & 0 deletions packages/@aws-cdk/aws-amplify-alpha/test/app.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ test('create an app connected to a GitHub repository', () => {
BasicAuthConfig: {
EnableBasicAuth: false,
},
CustomHeaders: '',
});

Template.fromStack(stack).hasResourceProperties('AWS::IAM::Role', {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"BasicAuthConfig": {
"EnableBasicAuth": false
},
"CustomHeaders": "",
"IAMServiceRole": {
"Fn::GetAtt": [
"AppRole1AF9B530",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"CacheConfig": {
"Type": "AMPLIFY_MANAGED_NO_COOKIES"
},
"CustomHeaders": "",
"IAMServiceRole": {
"Fn::GetAtt": [
"AppRole1AF9B530",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"BasicAuthConfig": {
"EnableBasicAuth": false
},
"CustomHeaders": "",
"IAMServiceRole": {
"Fn::GetAtt": [
"AppRole1AF9B530",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"BasicAuthConfig": {
"EnableBasicAuth": false
},
"CustomHeaders": "",
"IAMServiceRole": {
"Fn::GetAtt": [
"AppRole1AF9B530",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5af460d

Please sign in to comment.