Checking if require tc show command works before advertising fault injection capability #4434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will add a check to see if the
tc
tool that's installed on the host is using a compatible version before advertising the fault injection capability.Implementation details
checkTCShowTooling()
that will try callingtc -j q show dev <INTERFACE> parent 1:1
to see if the correct version oftc
is available to be used on the host. This will be called after checking that all of the tools are installed/bind mounted to the agent container just like with the modules check.netconfig
utility package that was added toecs-agent
to obtain the default network interface name on the hostexecwrapper
package that was added. toecs-agent
in order to make thetc
commands via OS exec callsTesting
Manual testing: Launched an Ubuntu 20 instance and installed ECS on it with these changes. Was able to see within the agent logs that the fault injection capability was not able to be advertised.
Checked within ECS whether the instance advertised the capability for fault injection
vs.
an advertised capability
New tests cover the changes: Yes
Description for the changelog
Enhancement: Add check if tc is compatible before advertising fault injection capability
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.