Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate Helm chart from the eks-chart repository #1367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bryantbiggs
Copy link
Member

Description of the issue

  • Add Helm chart from eks-charts repository
    • This chart should be published from this repository primarily due to 2 reasons:
      1. To deploy new versions of amazon-cloudwatch-agent artifacts in unison - both the image and the helm chart
      2. It is where the maintainers primarily operate and where users should come for feature requests, bugs/issues, documentation, etc.

The container image is already being published to Public ECR, the same should be done for the Helm chart which then allows both the image and the chart to be published together to Public ECR

We have opened a PR on the eks-charts repo to deprecate and remove this chart and direct users to this project going forward - aws/eks-charts#1171

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Describe what tests you have done.

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@bryantbiggs bryantbiggs requested a review from a team as a code owner October 3, 2024 16:06
Copy link
Contributor

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Oct 11, 2024
@bryantbiggs
Copy link
Member Author

Not stale

@github-actions github-actions bot removed the Stale label Oct 12, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Oct 20, 2024
@bryantbiggs
Copy link
Member Author

n

@github-actions github-actions bot removed the Stale label Oct 21, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Oct 28, 2024
@bryantbiggs
Copy link
Member Author

@aws/cloudwatch-agent who can I chat with about this Helm chart migration and deprecation?

@github-actions github-actions bot removed the Stale label Oct 29, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Nov 6, 2024
@bryantbiggs
Copy link
Member Author

Nope

@github-actions github-actions bot removed the Stale label Nov 7, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant