Refresh otel fork update workflow to account for added/removed packages. #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed the confighttp override in 0865173.
jefchien
reviewed
Apr 11, 2024
There was a problem hiding this comment.
This workflow is a bit outdated. It's missing a couple of our contrib dependencies, which is leading version drift. I think we should revisit this.
Missing
github.com/amazon-contributing/opentelemetry-collector-contrib/extension/awsproxy
github.com/amazon-contributing/opentelemetry-collector-contrib/internal/aws/proxy
github.com/amazon-contributing/opentelemetry-collector-contrib/internal/kubelet
github.com/amazon-contributing/opentelemetry-collector-contrib/pkg/stanza
github.com/amazon-contributing/opentelemetry-collector-contrib/extension/awsmiddleware
github.com/amazon-contributing/opentelemetry-collector-contrib/override/aws
|
Addressed @jefchien 's comment and alphabetized/refactored a bit. Workflow run in my fork: https://github.com/straussb/amazon-cloudwatch-agent/actions/runs/8651141047/job/23721186276 |
jefchien
reviewed
Apr 11, 2024
Co-authored-by: Jeffrey Chien <[email protected]>
straussb
changed the title
Co-authored-by: Jeffrey Chien <[email protected]>
jefchien
previously approved these changes
Apr 11, 2024
|
Looks like you need to do a go mod tidy |
jefchien
approved these changes
Apr 11, 2024
okankoAMZ
approved these changes
Apr 17, 2024
|
This PR was marked stale due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the confighttp override in 0865173.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.