update: Change ACK lab to use DynamoDB instead of RDS #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 10, 2023 17:21
…raform Addon with IRSA, IAM Policy and Role
… and kustomization for Carts service
…yaml, and added env variable in addons.tf
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@candonov could you review and test this PR? |
Per our sync this morning, @thiru85 demoed it and it looks good, @ybezsonov will run a test and review. |
|
Made the changes as discussed |
niallthomson
requested changes
Oct 26, 2023
website/docs/automation/controlplanes/ack/provision-resources.md
Outdated
Show resolved
Hide resolved
website/docs/automation/controlplanes/ack/provision-resources.md
Outdated
Show resolved
Hide resolved
website/docs/automation/controlplanes/ack/provision-resources.md
Outdated
Show resolved
Hide resolved
website/docs/automation/controlplanes/ack/provision-resources.md
Outdated
Show resolved
Hide resolved
website/docs/automation/controlplanes/ack/provision-resources.md
Outdated
Show resolved
Hide resolved
niallthomson
changed the title
|
Let me know if there are other changes needed |
ybezsonov
reviewed
Oct 30, 2023
website/docs/automation/controlplanes/ack/configure-application.md
Outdated
Show resolved
Hide resolved
website/docs/automation/controlplanes/ack/provision-resources.md
Outdated
Show resolved
Hide resolved
|
updated |
|
Looks like theres an issue with a link in the content? Website is failing to build https://github.com/aws-samples/eks-workshop-v2/actions/runs/6694950228/job/18192668662?pr=712#step:5:48 |
|
I pushed some minor changes to make sure the Dynamo table and IRSA role name are unique to the cluster name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds functionality to provision a DynamoDB table in AWS using AWS Controllers for Kubernetes (ACK) instead of an RDS instance, uses the Carts component of the Sample application, updates workshop/lab steps and adds new screenshots.
Which issue(s) this PR fixes:
Fixes #625
Quality checks
make test module="<module>"it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.