Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the eks-worshop-ide-cfn.yaml #689

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Conversation

ROunofF
Copy link
Contributor

@ROunofF ROunofF commented Oct 10, 2023

What this PR does / why we need it:

  • Correct cfn-lint errors and
  • Modify so that DiskSize Override work as expected
  • Added Cloud9Subnet to override subnet
  • Remove logic for partition resize as Cloud9 does it on reboot by default (added reboot)

Which issue(s) this PR fixes: #646 #688

Fixes #

Quality checks

  • My content adheres to the style guidelines
  • I ran make test or make e2e-test and it was successful

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit f604c5a
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/6525a0bcd84d5800084d5e1f
😎 Deploy Preview https://deploy-preview-689--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@niallthomson niallthomson merged commit bad5101 into aws-samples:main Oct 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: eks-workshop-ide-cfn.yaml fails to launch when default subnet has no internet access
2 participants