Aws iam console access2 #669
Conversation
…ion of the container - Added functionality to verify if C9_USER exist, it will grant access to the EKS via WS Console Access
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -0,0 +1,118 @@ | |||
| resource "kubernetes_cluster_role" "eks-console-dashboard-full-access-clusterrole" { | |||
There was a problem hiding this comment.
Is this file still needed with the logic in use-cluster? Will it not do the same thing? Or is there something else?
There was a problem hiding this comment.
Forgot to delete those files. I isn't needed.
There was a problem hiding this comment.
Unnecessary files removed.
hack/run-tests.sh
Outdated
| @@ -54,5 +54,5 @@ echo "Running test suite..." | |||
| $CONTAINER_CLI run $background_args \ | |||
| -v $SCRIPT_DIR/../website/docs:/content \ | |||
| -v $SCRIPT_DIR/../manifests:/manifests \ | |||
| -e 'EKS_CLUSTER_NAME' -e 'AWS_REGION' \ | |||
| -e 'EKS_CLUSTER_NAME' -e 'AWS_REGION' -e 'C9_USER' \ | |||
There was a problem hiding this comment.
Is this designed to cater for the code being developed in Cloud9? If I'm developing on my local laptop will this skip triggering the Cloud9 logic in the rest of the change?
There was a problem hiding this comment.
I needed it to emulate the C9 deployment in my local computer. But might be unnecessary, I'll do a test and remove it if it is not necessary.
There was a problem hiding this comment.
Variable removed
What this PR does / why we need it:
Which issue(s) this PR fixes:
It will grant access to the EKS through the AWS console when the user launched the cluster through Cloud9.
Fixes #620
Quality checks
make testormake e2e-testand it was successfulBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.