Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Continuous integration to update image with Flux #642

Merged
merged 17 commits into from
Oct 30, 2023

Conversation

ybezsonov
Copy link
Contributor

@ybezsonov ybezsonov commented Aug 18, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

#511
#389

Quality checks

  • My content adheres to the style guidelines

  • I ran make test or make e2e-test and it was successful

    EKS Workshop
    Automation
    Unknown
    Flux
    ✔ Flux (195788ms)
    ✔ Accessing AWS CodeCommit (83ms)
    ✔ Cluster bootstrap (22763ms)
    ✔ Deploying an application (84230ms)
    ✔ Continuous Integration and GitOps (50912ms)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Yuriy Bezsonov added 2 commits August 16, 2023 20:14
@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit a37a99d
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/653a602356ce190008d57e85
😎 Deploy Preview https://deploy-preview-642--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ybezsonov ybezsonov changed the title Ci2flux [feat] - Add Flux lab to demonstrate CI + Flux Image automation controller for image patching Sep 27, 2023
@ybezsonov ybezsonov marked this pull request as ready for review September 27, 2023 10:42
@csantanapr
Copy link
Member

This is ready for review @allamand @tsahiduek could you review?

@csantanapr
Copy link
Member

@niallthomson could you run an end2end test pipeline on this PR?

Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise good to merge

@csantanapr
Copy link
Member

Thank you so much @ybezsonov 🎉
I was able to test it and it works for me
@niallthomson please merge this when you have a chance

Copy link
Contributor

@niallthomson niallthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great PR as usual @ybezsonov I have made 1 request for a change I feel is needed before I can merge.

That being said there are gaps with the ability to test this lab effectively, as the main commands that would validate whether this works or not are being skipped. Given the timeline we're looking to get this in I'd be fine as long as we agree this can be addressed as a follow-up.

@niallthomson niallthomson changed the title [feat] - Add Flux lab to demonstrate CI + Flux Image automation controller for image patching update: Continuous integration to update image with Flux Oct 26, 2023
@niallthomson
Copy link
Contributor

Thanks for addressing those changes @ybezsonov This will be merged on Monday as the scope for our release tomorrow is locked.

@niallthomson niallthomson merged commit 05864a7 into aws-samples:main Oct 30, 2023
6 checks passed
@ybezsonov ybezsonov deleted the ci2flux branch March 7, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants