-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: Continuous integration to update image with Flux #642
Conversation
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is ready for review @allamand @tsahiduek could you review? |
@niallthomson could you run an end2end test pipeline on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, otherwise good to merge
Thank you so much @ybezsonov 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great PR as usual @ybezsonov I have made 1 request for a change I feel is needed before I can merge.
That being said there are gaps with the ability to test this lab effectively, as the main commands that would validate whether this works or not are being skipped. Given the timeline we're looking to get this in I'd be fine as long as we agree this can be addressed as a follow-up.
manifests/modules/automation/gitops/flux/.workshop/terraform/addon.tf
Outdated
Show resolved
Hide resolved
Add wait-for-lb Co-authored-by: Carlos Santana <[email protected]>
Co-authored-by: Carlos Santana <[email protected]>
Co-authored-by: Carlos Santana <[email protected]>
Thanks for addressing those changes @ybezsonov This will be merged on Monday as the scope for our release tomorrow is locked. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
#511
#389
Quality checks
My content adheres to the style guidelines
I ran
make test
ormake e2e-test
and it was successfulEKS Workshop
Automation
Unknown
Flux
✔ Flux (195788ms)
✔ Accessing AWS CodeCommit (83ms)
✔ Cluster bootstrap (22763ms)
✔ Deploying an application (84230ms)
✔ Continuous Integration and GitOps (50912ms)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.