Fix deprecated patches support with kustomize for k8s v1.27.0 release #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This will take a little time to test due to the number of labs touched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The k8s v1.27.0 release notes talk about a major kustomize update. Specifically mentioning deprecating old style patches support. The newest documented format doesn't allow for YAML document merges, unless a "path:" key is provided.
This fixes all kustomize patch documents in all modules, and enables the workshop to be migrated to kubectl >= 1.27.0
It also fixes the
yarn startandyarn buildcommands for local development.Which issue(s) this PR fixes:
Fixes # #548
Quality checks
make testormake e2e-testand it was successfulBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.