Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Spot instances with Managed Node Groups #592

Merged
merged 22 commits into from
Nov 3, 2023

Conversation

bijithnair
Copy link
Contributor

@bijithnair bijithnair commented Jul 10, 2023

What this PR does / why we need it:

This PR helps user understands how to setup EKS managed node groups with Spot capacity

Which issue(s) this PR fixes:

#455

Fixes #

Quality checks

  • My content adheres to the style guidelines
  • I ran make test or make e2e-test and it was successful

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit 9d80f04
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/65446028a52ade0008983b18
😎 Deploy Preview https://deploy-preview-592--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

svennam92

This comment was marked as resolved.

@bijithnair
Copy link
Contributor Author

Due to the recent changes to the workshop, Kustomize location got changed and need fix

svennam92
svennam92 previously approved these changes Oct 10, 2023
Copy link
Contributor

@niallthomson niallthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of general questions before I really dig in to the content.

First, I see a prepare-environment on the index page, but no lab indicator. I'm thinking that perhaps we should just re-structure the MNG lab in to several separate labs. The existing content goes in something like "MNG basics", then we add standalone labs for Spot and Graviton2. I think its likely that customers might want to skip the easy stuff but still learn about the latter.

Second, it would be good to cover instance diversification since this is pretty critical with Spot in MNG. We have this outlined in the Finhack workshop: https://catalog.us-east-1.prod.workshops.aws/workshops/c4ab40ed-0299-4a4e-8987-35d90ba5085e/en-US/050-ec2-spot-instances/selecting-instance-types

template:
spec:
nodeSelector:
capacity_type: managed_spot
Copy link
Contributor

@niallthomson niallthomson Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this use the built-in label instead of a custom one? Shouldn't be needed.

@niallthomson niallthomson added this to the re:Invent 2023 milestone Oct 20, 2023
@niallthomson niallthomson changed the title Content related to EKS Workshop V2 - Spot new: Spot instances with Managed Node Groups Oct 26, 2023
@niallthomson
Copy link
Contributor

@bijithnair thanks for all the work you put in to this content!

@niallthomson niallthomson merged commit 95ba059 into aws-samples:main Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants