-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Spot instances with Managed Node Groups #592
Conversation
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Due to the recent changes to the workshop, Kustomize location got changed and need fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of general questions before I really dig in to the content.
First, I see a prepare-environment
on the index page, but no lab indicator. I'm thinking that perhaps we should just re-structure the MNG lab in to several separate labs. The existing content goes in something like "MNG basics", then we add standalone labs for Spot and Graviton2. I think its likely that customers might want to skip the easy stuff but still learn about the latter.
Second, it would be good to cover instance diversification since this is pretty critical with Spot in MNG. We have this outlined in the Finhack workshop: https://catalog.us-east-1.prod.workshops.aws/workshops/c4ab40ed-0299-4a4e-8987-35d90ba5085e/en-US/050-ec2-spot-instances/selecting-instance-types
template: | ||
spec: | ||
nodeSelector: | ||
capacity_type: managed_spot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this use the built-in label instead of a custom one? Shouldn't be needed.
@bijithnair thanks for all the work you put in to this content! |
What this PR does / why we need it:
This PR helps user understands how to setup EKS managed node groups with Spot capacity
Which issue(s) this PR fixes:
#455
Fixes #
Quality checks
make test
ormake e2e-test
and it was successfulBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.