Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds missing permsions to the 'eks-workshop-ide-ec2' IAM policy #1199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajmoorexyz
Copy link

@ajmoorexyz ajmoorexyz commented Dec 27, 2024

What this PR does / why we need it:

This PR resolves the IAM issue reported here #1106

Without this change the following command fails which makes learning about EFS incredibly frustrating.

prepare-environment fundamentals/storage/efs

Which issue(s) this PR fixes:

Fixes # #1106

Quality checks

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit ffd45d2
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/676f3e4f167d21000805ea3a
😎 Deploy Preview https://deploy-preview-1199--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ajmoorexyz
Copy link
Author

I've tested this by applying the IAM change manually. Testing changes to the ide aren't mentioned in https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md and fall into the What if my module can't be tested? camp.

Please advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant