This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Explain why we can't dynamically update resource values on a running pod #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding some explanation on why the user can't simply update the memory resources for the existing pod.
Update readme.adoc
Update readme.adoc
buzzsurfr
reviewed
Jun 7, 2018
| @@ -339,6 +339,10 @@ Watch the status of the Pod: | |||
|
|
|||
| `OOMKilled` shows that the container was terminated because it ran out of memory. | |||
|
|
|||
| To correct this, we'll need to re-create the pod with higher memory limits. | |||
|
|
|||
| Although it may be instinctive to simply adjust the memory limit in the existing pod definition and re-apply it, https://github.com/kubernetes/kubernetes/issues/39060#issuecomment-268449812[Kubernetes does not currently support changing resource limits on running pods], so we'll need to first delete the existing pod, then recreate it. | |||
There was a problem hiding this comment.
Is it necessary to reference the issue? Can we instead highlight that Kubernetes does not support in-place adjustments to pod resources?
If this will be fixed, then I can see tracking the issue. However, if it's not on the roadmap, then we should leave the issue out.
There was a problem hiding this comment.
I was just being verbose :) No need to include the link reference.
There was a problem hiding this comment.
Can you fix and send a new commit?
| @@ -359,7 +363,7 @@ Get more details about the resources allocated to the Pod: | |||
|
|
|||
| === Quality of service | |||
|
|
|||
| Kubernetes opportunistically scavenge the difference between request and limit if they are not used by the Containers. This allows Kubernetes to oversubscribe nodes, which increases utilization, while at the same time maintaining resource guarantees for the containers that need guarantees. | |||
| Kubernetes opportunistically scavenges the difference between request and limit if they are not used by the Containers. This allows Kubernetes to oversubscribe nodes, which increases utilization, while at the same time maintaining resource guarantees for the containers that need guarantees. | |||
|
Can you please fix conflicts and resubmit PR? |
|
@buzzsurfr new issue and PR available at #551 and #552 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.