automatically set ELB_LIST if not provided #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thanks for the PR. Although it might not be the best practice, there could be multiple applications running on the same instance but behind different ELB at the same time. It could be error-prone to automatically deregister and register instance from all ELBs it's bund to. I think it would be helpful if we provide this feature as an opt-in option instead of default behavior. |
|
I've updated the PR to make this feature opt-in. |
|
Could you please confirm this contribution is under the terms of the Apache 2.0 license. Thanks. |
|
Confirmed, Apache 2.0 license applies to this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need to manually set
ELB_LISTwhen not using an auto-balancer, and removes the step in the README.md where this is required.In
deregister_from_elb.sh, ifELB_LISTis empty this PR calls the existingget_elb_listfunction to automatically find all load balancers the instance is currently registered to, then writes this list to a temp file (/tmp/elblist).In
register_with_elb.sh, ifELB_LISTis empty this PR reads the list of previously-registered load balancers from the temp file (/tmp/elblist).The behavior is unchanged when an auto-scaling group is used.