-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sonar issues #1313
fix: sonar issues #1313
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
============================================
+ Coverage 79.65% 79.95% +0.29%
Complexity 639 639
============================================
Files 73 71 -2
Lines 2345 2335 -10
Branches 253 253
============================================
- Hits 1868 1867 -1
+ Misses 397 388 -9
Partials 80 80
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
It's not finished @kozub ... If you want to do a bit, feel free ;) it's not the most exciting task so I just started. but we certainly don't need to fix everything, we can sort out what is important or not |
Didn't noticed that it's a draft. I should have a coffee before reviewing it ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far ;-)
Issue #, if available:
Description of changes:
Fixed a bunch of findings in sonar
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.