fix: point source maps to TS files #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williazz
changed the title
|
question: have you tested this to verify they work now? |
yes used this offline with a rum user |
ps863
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the row and column numbers will be wrong when JSErrors are applied to source maps, because they will mapped to the compiled JS files, not the original TS files.
TypeScript is supposed to output inline source maps for the JS files that they ultimately create. These TS->JS source maps are necessary so that the line number is actually correct when we debug our TS files. Webpack also needs this information so it knows what to include in the final CDN distro. Currently, we are vending the bad source maps to https://client.rum.us-east-1.amazonaws.com/1.x/cwr.js.map; however, the source map distributions are not advertised.
Documentation for TS -> JS -> Webpack source maps
https://webpack.js.org/guides/typescript/#source-maps
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.