Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve staging bucket name & minor fixes in main build #75

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

srprash
Copy link
Contributor

@srprash srprash commented Feb 26, 2024

Description of changes:

  • The commit short sha was incorrectly getting set to the package version.
  • Improved s3 bucket name secret variable to be more specific what is being used.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srprash srprash requested a review from a team February 26, 2024 21:50
@srprash srprash merged commit fc3f57f into main Feb 26, 2024
@srprash srprash deleted the main-build-minor-fix branch February 26, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants