Perf #74
Merged
Perf #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpierce
force-pushed
the
perf
branch
2 times, most recently
from
cf6f75a to
72b32ac
Compare
AsakerMohd
approved these changes
Feb 26, 2024
…rformance-tests In this commit we are copying all content from https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/benchmark-overhead to https://github.com/aws-observability/aws-otel-python-instrumentation/tree/main/performance-tests. We will be using benchmark-overhead as a template to building our own performance tests, so initially we are just copying all content over. Much of this content will be changed and/or deleted in upcoming commits, but for now, it's just a raw copy-paste.
In this commit, we are making spotless work, as I found out that spotless is not being run in the upstream for benchmark-overhead. To achive this, I've added a license file to `scripts` and updated build.gradle.kts to reference it. Then I ran spotlessApply to bring the code up to expectations. In future commits, we will automatically run spotless to ensure code is up to standards on every commit.
We recently added Java code to this package to support performance tests. To ensure we maintain a high bar for code quality, we enabled spotless and in this commit, we enable running spotless on all PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy benchmark-overhead from opentelemetry-java-instrumentation to performance-tests
In this commit we are copying all content from https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/benchmark-overhead to https://github.com/aws-observability/aws-otel-python-instrumentation/tree/main/performance-tests. We will be using benchmark-overhead as a template to building our own performance tests, so initially we are just copying all content over. Much of this content will be changed and/or deleted in upcoming commits, but for now, it's just a raw copy-paste.
This commit ONLY copies and pastes directly from upstream using the following command:
cp opentelemetry-java-instrumentation/benchmark-overhead/* ../python-sdk/aws-otel-python-instrumentation/performance-tests -rAdditionally, there are 4 commits to fix build and code quality issues:
scriptsand updated build.gradle.kts to reference it. Then I ran spotlessApply to bring the code up to expectations. In future commits, we will automatically run spotless to ensure code is up to standards on every commit.afterallto avoid failures seen hereIn future commits, we will start updating the code, fix the copywrite notices, and removing unrelated code.
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.