Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ownership #5

Merged
merged 17 commits into from
Jan 9, 2024
Merged

Add ownership #5

merged 17 commits into from
Jan 9, 2024

Conversation

zzhlogin
Copy link
Contributor

@zzhlogin zzhlogin commented Jan 5, 2024

Add AWS Distro with to create a basic file structure.
Add unit tests workflow.

@zzhlogin zzhlogin requested a review from a team January 5, 2024 23:33
thpierce
thpierce reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@thpierce thpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, but we need to tighten up naming.

aws-otel-distro/src/opentelemetry/distro/version.py Outdated Show resolved Hide resolved
aws-otel-distro/src/opentelemetry/distro/aws_distro.py Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
aws-otel-distro/README.rst Outdated Show resolved Hide resolved
aws-otel-distro/pyproject.toml Outdated Show resolved Hide resolved
aws-otel-distro/pyproject.toml Outdated Show resolved Hide resolved
aws-otel-distro/pyproject.toml Outdated Show resolved Hide resolved
aws-otel-distro/src/opentelemetry/distro/aws_distro.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
thpierce
thpierce reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@thpierce thpierce left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. You did miss one directory level tho, can you fix:opentelemetry-distro/src/opentelemetry/distro/ -> opentelemetry-distro/src/amazon/opentelemetry/distro/

opentelemetry-distro/pyproject.toml Outdated Show resolved Hide resolved
opentelemetry-distro/README.rst Outdated Show resolved Hide resolved
opentelemetry-distro/src/opentelemetry/distro/aws_opentelemetry_configurator.py Outdated Show resolved Hide resolved
opentelemetry-distro/tests/test_aws_distro.py Outdated Show resolved Hide resolved
scripts/eachdist.py Outdated Show resolved Hide resolved
opentelemetry-distro/src/opentelemetry/distro/version.py Outdated Show resolved Hide resolved
thpierce
thpierce approved these changes Jan 9, 2024
View reviewed changes
.pylintrc Show resolved Hide resolved
@zzhlogin zzhlogin merged commit f4bb1dd into main Jan 9, 2024
16 checks passed
@zzhlogin zzhlogin deleted the add_onwership branch January 9, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thpierce thpierce thpierce approved these changes

@srprash srprash Awaiting requested review from srprash

@AsakerMohd AsakerMohd Awaiting requested review from AsakerMohd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzhlogin @thpierce