Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws.pulse.over.midlina attribute for lambda spans #266

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add aws.pulse.over.midlina attribute for lambda spans #266

merged 1 commit into from
Sep 30, 2024

Conversation

wangzlei
Copy link
Contributor

Description of changes:

Add aws.pulse.over.midlina for lambda spans when AppSignals is enabled, so server side can use it to determine whether it should generate EMF metrics


2024-09-27T15:19:32.789-07:00 | 'faas.name': 'aws-opentelemetry-distro-nodejs', | 2024/09/27/[$LATEST]af2cea6e28a94c24aa098ed39567d85b
-- | -- | --
  | 2024-09-27T15:19:32.789-07:00 | 'faas.version': '$LATEST', | 2024/09/27/[$LATEST]af2cea6e28a94c24aa098ed39567d85b
  | 2024-09-27T15:19:32.789-07:00 | 'faas.instance': '2024/09/27/[$LATEST]af2cea6e28a94c24aa098ed39567d85b', | 2024/09/27/[$LATEST]af2cea6e28a94c24aa098ed39567d85b
  | 2024-09-27T15:19:32.789-07:00 | 'aws.log.group.names': '/aws/lambda/aws-opentelemetry-distro-nodejs', | 2024/09/27/[$LATEST]af2cea6e28a94c24aa098ed39567d85b
  | 2024-09-27T15:19:32.789-07:00 | 'aws.pulse.over.midlina': 'true'

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@wangzlei wangzlei requested a review from a team as a code owner September 28, 2024 01:16
@mxiamxia mxiamxia merged commit 825fe58 into aws-observability:main Sep 30, 2024
12 checks passed
wangzlei added a commit that referenced this pull request Oct 3, 2024
@wangzlei wangzlei mentioned this pull request Oct 3, 2024
wangzlei added a commit that referenced this pull request Oct 3, 2024
*Description of changes:*

revert
#266

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants