Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support a list of new AWS resources for AWS Python SDK #265

Merged
merged 13 commits into from
Sep 30, 2024

Conversation

yiyuan-he
Copy link
Contributor

@yiyuan-he yiyuan-he commented Sep 25, 2024

Description of changes:

These changes add auto-instrumentation support for the following AWS resources. Additionally, a new attribute for aws.remote.resource.cfn.primary.identifier is also added for each new resource.

Test Plan:

Set up a client-server with auto-instrumentation to verify that the correct span data is being generated.

sns_topic_arn_span_data_verification
secretsmanager_secret_arn_span_data_verification
sfn_statemachine_arn_span_data_verification
sfn_activity_arn_span_data_verification
lambda_function_name_span_data_verification
lambda_event_source_mapping_uuid_span_data_verification

Unit Tests for Instrumentation Patches and AWS Metric Attribute Generators.

instrumentation_patch_unit_test_verification
aws_metric_attribute_generator_unit_test_verification

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yiyuan-he yiyuan-he requested a review from a team as a code owner September 25, 2024 23:38
@yiyuan-he yiyuan-he requested a review from mxiamxia September 25, 2024 23:39
@yiyuan-he
Copy link
Contributor Author

Synced offline with @mxiamxia and removed support for Kinesis Consumer Stream. It seems there is still some ambiguity regarding this resource that we need to resolve before we can support it.

@yiyuan-he yiyuan-he closed this Sep 26, 2024
@yiyuan-he yiyuan-he reopened this Sep 26, 2024
@yiyuan-he yiyuan-he merged commit 831b76b into aws-observability:main Sep 30, 2024
12 checks passed
mxiamxia pushed a commit to aws-observability/aws-otel-js-instrumentation that referenced this pull request Dec 16, 2024
…S SDK (#121)

*Description of changes:*

Adding support for new AWS resources in JS SDK. Part of an ongoing
project to increase the ADOT SDK support in Node and .NET.

Changes in this PR support the exact same features as the Python
version:

aws-observability/aws-otel-python-instrumentation#265

Manual Testing:
<img width="1236" alt="Screenshot 2024-11-15 at 1 36 01 PM"
src="https://github.com/user-attachments/assets/7480f865-2927-4376-91b5-76048b0bcdf4">
<img width="1234" alt="Screenshot 2024-11-15 at 2 07 05 PM"
src="https://github.com/user-attachments/assets/1a5d00b4-9ac8-45e9-b51d-02d7c669f5f1">
<img width="939" alt="Screenshot 2024-11-15 at 2 26 10 PM"
src="https://github.com/user-attachments/assets/120892ec-03cf-4b70-80c7-167369cd9e27">
<img width="996" alt="Screenshot 2024-11-18 at 9 47 33 AM"
src="https://github.com/user-attachments/assets/08019f4c-507c-46cf-baa0-db77a4175d02">
<img width="934" alt="Screenshot 2024-11-18 at 9 57 22 AM"
src="https://github.com/user-attachments/assets/3fb79fa9-689f-4361-b671-79e23c68193d">
<img width="852" alt="Screenshot 2024-11-18 at 10 00 34 AM"
src="https://github.com/user-attachments/assets/bde63f88-cdbc-43c9-aa16-068790556ebe">

Unit Tests for Instrumentation Patches and Metric Attribute Generators:

<img width="1070" alt="image"
src="https://github.com/user-attachments/assets/df01814c-49fb-4561-879b-c88cedb35e5c">

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants