Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SecretsManager and StepFunctions support. #203

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

zzhlogin
Copy link
Contributor

@zzhlogin zzhlogin commented Jun 5, 2024

Add SecretsManager and StepFunctions Support with the following change:

  1. Add patch _SecretsManagerExtension and _StepFunctionsExtension, extract SecretARN, activityARNand stateMachineArn add into span attributes. The attributes will be retrieved from both request and response context.
    For SecretARN, it can be retrieved from two context paramters: 1). ARN 2). SecretId: SecretId can be secret name or secret arn, we only use it if it is an arn.

  2. Populate RemoteResourceType and RemoteResourceIdentifier for SecretsManager and StepFunctions in ADOT python and update unit test and contract test to verify ADOT python performance.

  3. Contract test: for test_stepfunctions_fault, since it is not straightforward to trigger 500 CLientError directly, we register 500 events for the specific API call to simulate 500 scenario.

Testing: E2E test performed to confirm trace, metrics and service maps are generated:

secret manager:
trace:
Screenshot 2024-06-06 at 8 03 23 PM
metrics:
Screenshot 2024-06-06 at 8 07 08 PM

step function:
trace:
Screenshot 2024-06-06 at 8 04 38 PM
metrics:
Screenshot 2024-06-06 at 8 08 10 PM

Service Map:
Screenshot 2024-06-06 at 8 05 39 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zzhlogin zzhlogin requested a review from a team as a code owner June 5, 2024 17:38
@zzhlogin zzhlogin changed the title Add secretsManager and StepFunction support (NOT READY). Add SecretsManager and StepFunctions support. Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants