Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AwsAttributePropagatingSpanProcessor. #14

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Add AwsAttributePropagatingSpanProcessor. #14

merged 9 commits into from
Jan 12, 2024

Conversation

zzhlogin
Copy link
Contributor

In this commit, we are implementing AwsAttributePropagatingSpanProcessor and AwsAttributePropagatingSpanProcessorBuilder. As much as possible, we are attempting to mirror the implementation of these class found in https://github.com/aws-observability/aws-otel-java-instrumentation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zzhlogin zzhlogin requested a review from a team January 11, 2024 19:59
Copy link
Contributor

@thpierce thpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add basic unit tests to ensure we can instantiate these classes and invoke their simplest method.

@zzhlogin
Copy link
Contributor Author

Lets add basic unit tests to ensure we can instantiate these classes and invoke their simplest method.

Added

@zzhlogin zzhlogin merged commit 6d73154 into main Jan 12, 2024
16 checks passed
@zzhlogin zzhlogin deleted the attribute_sp branch January 12, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants