Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cp -r support to cp-utility tool #108

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Add cp -r support to cp-utility tool #108

merged 1 commit into from
Oct 24, 2024

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Oct 24, 2024

Issue #, if available:
ADOT SDK instrumentation Docker Images only support cp -a copy command so that the CWAgentOperator can extract the instrumentation SDK via cp -a, but upstream OTel Operator has changed a few months ago to use cp -r instead of -a to copy files from the OTel SDK Instrumentation Images. Today, OTel Operator is not compatible with some of the ADOT SDKs, and in the future, CWAgent Operator may also change to use cp -r as well

Description of changes:

Testing:

  • Tested on PetClinic Sample App's NodeJS Service with latest OTel Operator + Collector

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jj22ee jj22ee requested a review from a team as a code owner October 24, 2024 23:31
@mxiamxia mxiamxia merged commit 901a357 into main Oct 24, 2024
9 checks passed
@mxiamxia mxiamxia deleted the scratch-copy-r branch October 24, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants