Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Input Validation Tests for all ADOT JS User-Configurable Environment Variables #102

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add Input Validation Tests for all ADOT JS User-Configurable Environment Variables #102

merged 1 commit into from
Oct 11, 2024

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Oct 11, 2024

Issue #, if available:

Description of changes:
Add unit tests for user-configurable environment variables that are not currently tested:

OTEL_TRACES_SAMPLER
OTEL_TRACES_SAMPLER_ARG
OTEL_TRACES_EXPORTER
OTEL_NODE_RESOURCE_DETECTORS
OTEL_AWS_APPLICATION_SIGNALS_ENABLED
OTEL_EXPORTER_OTLP_TRACES_PROTOCOL
OTEL_EXPORTER_OTLP_METRICS_PROTOCOL
OTEL_EXPORTER_OTLP_PROTOCOL
OTEL_AWS_APPLICATION_SIGNALS_EXPORTER_ENDPOINT

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jj22ee jj22ee requested a review from a team as a code owner October 11, 2024 17:07
@pxaws pxaws merged commit 2907367 into main Oct 11, 2024
9 checks passed
@pxaws pxaws deleted the input-validation-tests branch October 11, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxaws pxaws pxaws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jj22ee @pxaws