-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure SDK when running in Lambda environment #950
Conversation
...ftware/amazon/opentelemetry/javaagent/providers/AwsApplicationSignalsCustomizerProvider.java
Outdated
Show resolved
Hide resolved
disabledResourceProviders.add("io.opentelemetry.contrib.aws.resource.EcsResourceProvider"); | ||
disabledResourceProviders.add("io.opentelemetry.contrib.aws.resource.EksResourceProvider"); | ||
propsOverride.put( | ||
OTEL_DISABLED_RESOURCE_PROVIDERS_CONFIG, String.join(",", disabledResourceProviders)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a way to verify it? either manually or by unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be only verified manually that the functionality works. Unit test can likely only tell if the config was set properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do a manual check to verify this.
Description of changes:
The following behaviors are implemented when the ADOT Java SDK is running in a Lambda environment:
OtlpUdpSpanExporter
to export spans to Lambda agent over UDP.otel.java.disabled.resource.providers
configuration.otel.bsp.max.export.batch.size
to 10 for the auto-configured BatchSpanProcessor that exports the sampled spans.AwsUnsampledOnlySpanProcessor
. Also, setting the batch size for theAwsUnsampledOnlySpanProcessor
to be 10.Compare to the ADOT Python implementation: aws-observability/aws-otel-python-instrumentation#257
Testing
AwsApplicationSignalsCustomizerProvider
does not exist and is high effort to add it with this PR.maxExportBatchSize
is 10 for the default auto-configured BatchSpanProcessorBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.