Add JMX contract tests #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
reviewed
Oct 25, 2024
...test/java/software/amazon/opentelemetry/appsignals/test/misc/jmx/KafkaBrokerMetricsTest.java
Outdated
Show resolved
Hide resolved
...s/src/test/java/software/amazon/opentelemetry/appsignals/test/utils/MockCollectorClient.java
Outdated
Show resolved
Hide resolved
appsignals-tests/images/kafka/kafka-consumers/src/main/java/App.java
Outdated
Show resolved
Hide resolved
jefchien
force-pushed
the
contract-tests
branch
2 times, most recently
from
98dcaa6
to
82cc9be
Compare
bjrara
approved these changes
Nov 1, 2024
bjrara
force-pushed
the
contract-tests
branch
from
82cc9be
to
13ec00a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Adds contract tests to verify the expected behavior of the following changes:
Starts up sample apps with the instrumented SDK and verifies that metrics are received for each of the supported JMX target systems.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.