-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic to instrument AWS Lambda functions using Application Signals #136
Open
AsakerMohd
wants to merge
19
commits into
main
Choose a base branch
from
lambdaLayer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vastin
reviewed
Nov 14, 2024
src/AWS.Distro.OpenTelemetry.AutoInstrumentation/LambdaWrapper.cs
Outdated
Show resolved
Hide resolved
src/AWS.Distro.OpenTelemetry.AutoInstrumentation/LambdaWrapper.cs
Outdated
Show resolved
Hide resolved
sample-applications/lambda-test-apps/SimpleLambdaFunction/README.md
Outdated
Show resolved
Hide resolved
vastin
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is a big change that includes multiple important things to support AWS Lambda function instrumentation:
Microsoft.Extensions.Logging.Console
since it's net core specific. This improves the net6 and net8 support.LambdaWrapper.cs
. This will be the main entry point as the handler. It will then call the original lambda handler and then calls forceFlush. This ensures that traces are flushed when the Lambda function finishes execution. This also includes updates to theinstrument.sh
script. When setting the special lambda env varAWS_LAMBDA_EXEC_WRAPPER=/opt/instrument.sh
, the lambda runtime executes this script to add OTEL specific env vars to instrument the function.Testing:
Tested by running the build-and-deploy.sh. This deployed the sample app and the lambda layer. After executing the lambda layer, the traces were visible in both the xray console and the application signals console.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.