pin markdown lint in workflows to 3.12.2 #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasireddy99
changed the title
alexperez52
reviewed
Nov 15, 2024
| @@ -49,7 +49,7 @@ jobs: | |||
| echo "MDS=$(git diff --name-only --diff-filter=ACMRTUXB $(git merge-base origin/${{ github.event.pull_request.base.ref }} ${{ github.event.pull_request.head.sha }}) ${{ github.event.pull_request.head.sha }} | grep .md$ | grep -v vendor/ | xargs)" >> $GITHUB_ENV | |||
|
|
|||
| - name: Install markdown-link-check | |||
| run: npm install -g markdown-link-check | |||
| run: npm install -g markdown-link-check@3.12.2 | |||
There was a problem hiding this comment.
when do we expect to be able to unpin this?
There was a problem hiding this comment.
We shall unpin once the issue is resolved upstream - tcort/markdown-link-check#369. No ETA atm, but this should be fine for now.
alexperez52
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix workflows and check-links
Pinning markdown-link-check to v3.12.2 because of this tcort/markdown-link-check#369
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.