Skip to content

Commit

Permalink
Merge pull request #46 from SPHTech-Platform/fix-implied-description
Browse files Browse the repository at this point in the history
Fix ram share for top level pool
  • Loading branch information
drewmullen authored Jan 5, 2023
2 parents e21de52 + f2d8ea5 commit 3e84a3c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,14 @@ The IPAM `operating_region` variable must be set for the primary Region in your

| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.15.0 |
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3.0 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.73.0 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | 4.17.1 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.73.0 |

## Modules

Expand Down
4 changes: 2 additions & 2 deletions modules/sub_pool/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@

| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.15.0 |
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3.0 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.73.0 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | 4.17.1 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.73.0 |

## Modules

Expand Down
4 changes: 2 additions & 2 deletions modules/sub_pool/main.tf
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
locals {
description = var.pool_config.description == null ? var.implied_description : var.pool_config.description
description = var.pool_config.description == null ? replace(var.implied_description, "/", "-") : var.pool_config.description

name = var.pool_config.name == null ? var.implied_name : var.pool_config.name
tags = merge(var.pool_config.tags, {
Expand Down Expand Up @@ -45,7 +45,7 @@ resource "aws_vpc_ipam_pool_cidr" "sub" {
resource "aws_ram_resource_share" "sub" {
count = local.ram_share_enabled ? 1 : 0

name = replace(var.implied_description, "/", "-")
name = local.description

tags = local.tags
}
Expand Down

0 comments on commit 3e84a3c

Please sign in to comment.