Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fargate-serverless pattern #2021

Merged
merged 5 commits into from
Sep 27, 2024
Merged

fix: Fargate-serverless pattern #2021

merged 5 commits into from
Sep 27, 2024

Conversation

rodrigobersa
Copy link
Contributor

Description

Adding a toleration for app-2048 to fit Fargate nodes Taints.

$ kubectl get nodes fargate-ip-10-0-0-1.us-west-2.compute.internal -o yaml | yq .spec.taints
- effect: NoSchedule
  key: eks.amazonaws.com/compute-type
  value: fargate
kubectl -n app-2048 get deployments.apps app-2048 -o yaml | yq .spec.template.spec.tolerations
- effect: NoSchedule
  key: eks.amazonaws.com/compute-type
  operator: Equal
  value: fargate

Motivation and Context

  • Complement for PR #418 from Addons repo.

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@rodrigobersa rodrigobersa marked this pull request as ready for review September 26, 2024 23:47
@rodrigobersa rodrigobersa requested a review from a team as a code owner September 26, 2024 23:47
@rodrigobersa rodrigobersa merged commit e6c38b1 into main Sep 27, 2024
5 checks passed
@rodrigobersa rodrigobersa deleted the fix/fargate-serverless branch September 27, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants