Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correct mis-spellings, ignore files with generated content from pre-commit checks #2015

Merged
merged 1 commit into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ repos:
rev: v8.13.3
hooks:
- id: cspell
args: [--exclude, 'ADOPTERS.md', --exclude, '.pre-commit-config.yaml', --exclude, '.gitignore', --exclude, '*.drawio', --exclude, 'mkdocs.yml', --exclude, '.helmignore', --exclude, '.github/workflows/*', --exclude, 'patterns/istio-multi-cluster/*', --exclude, 'patterns/blue-green-upgrade/*']
args: [--exclude, 'ADOPTERS.md', --exclude, '.pre-commit-config.yaml', --exclude, '.gitignore', --exclude, '*.drawio', --exclude, 'mkdocs.yml', --exclude, '.helmignore', --exclude, '.github/workflows/*', --exclude, 'patterns/istio-multi-cluster/*', --exclude, 'patterns/blue-green-upgrade/*', --exclude, '/patterns/vpc-lattice/cross-cluster-pod-communication/*', --exclude, 'patterns/bottlerocket/*', --exclude, 'patterns/nvidia-gpu-efa/generate-efa-nccl-test.sh']
- repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks
rev: v2.14.0
hooks:
Expand All @@ -19,7 +19,7 @@ repos:
- id: detect-aws-credentials
args: [--allow-missing-credentials]
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.92.1
rev: v1.96.1
hooks:
- id: terraform_fmt
- id: terraform_docs
Expand Down
9 changes: 9 additions & 0 deletions docs/cSpell_dict.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
acmpca
acmca_arn
addrs
adduser
adot
agones
akuity
alekc
alertmanager
algbw
ALLOWVOLUMEEXPANSION
amazonlinux
Expand Down Expand Up @@ -56,6 +58,7 @@ daemonset
datasource
dcgm
distro
dockerhub
ecrpublic
ecsdemo
ecsfrontend
Expand Down Expand Up @@ -108,19 +111,25 @@ mktemp
mountpoint
mpijob
mpijobs
mpirun
mtls
nccl
netcat
nics
nodeadm
nodegroup
nodeport
nopasswd
nvme
odcr
oidc
openmpi
openpolicyagent
persistentvolume
pkce
pubkey
pullthroughcache
ecrpullthroughcache
privateca
privatelink
prometheusservice
Expand Down
2 changes: 1 addition & 1 deletion patterns/ecr-pull-through-cache/ecr.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module "secrets_manager" {

name = "ecr-pullthroughcache/docker"
secret_string = jsonencode(var.docker_secret)
recovery_window_in_days = 0 # Set to 0 for testing purposes, this will immediatly delete the secret. This action is irreversible. https://docs.aws.amazon.com/secretsmanager/latest/apireference/API_DeleteSecret.html
recovery_window_in_days = 0 # Set to 0 for testing purposes, this will immediately delete the secret. This action is irreversible. https://docs.aws.amazon.com/secretsmanager/latest/apireference/API_DeleteSecret.html
}

module "ecr" {
Expand Down
2 changes: 1 addition & 1 deletion patterns/ecr-pull-through-cache/variables.tf
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
variable "docker_secret" {
description = "Inform your docker username and accessToken to allow pullTroughCache to get images from Docekr.io. E.g. `{username='user',accessToken='pass'}`"
description = "Inform your docker username and accessToken to allow pullTroughCache to get images from Docker.io. E.g. `{username='user',accessToken='pass'}`"
type = object({
username = string
accessToken = string
Expand Down
2 changes: 1 addition & 1 deletion patterns/karpenter-mng/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ provider "aws" {
region = local.region
}

# This provider is required for ECR to autheticate with public repos. Please note ECR authetication requires us-east-1 as region hence its hardcoded below.
# This provider is required for ECR to authenticate with public repos. Please note ECR authentication requires us-east-1 as region hence its hardcoded below.
# If your region is same as us-east-1 then you can just use one aws provider
provider "aws" {
alias = "ecr"
Expand Down
2 changes: 1 addition & 1 deletion patterns/karpenter/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ provider "aws" {
region = local.region
}

# This provider is required for ECR to authenticate with public repos. Please note ECR authetication requires us-east-1 as region hence its hardcoded below.
# This provider is required for ECR to authenticate with public repos. Please note ECR authentication requires us-east-1 as region hence its hardcoded below.
# If your region is same as us-east-1 then you can just use one aws provider
provider "aws" {
alias = "ecr"
Expand Down
Loading