Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Availability Zone AZs Data Source to filter Local Zones #1995

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

rodrigobersa
Copy link
Contributor

Description

Add a filter block on the availability zones data to exclude Local Zones.
Removing version filter for Karpenter helm chart on Bottlerocket pattern.

Motivation and Context

Patterns deployments fail when Local Zones are enabled in the account. Adding filter to avoid the deployment on accounts with Local Zones enabled.
The parameter for the chart version is wrong on the Bottlerocket pattern, falling on the module default. Removing the version constraint.

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@rodrigobersa rodrigobersa changed the title Fix: Availability Zone AZs Data Source to filter Local Zones fix: Availability Zone AZs Data Source to filter Local Zones Aug 12, 2024
@rodrigobersa rodrigobersa marked this pull request as ready for review August 12, 2024 02:17
@rodrigobersa rodrigobersa requested a review from a team as a code owner August 12, 2024 02:17
@@ -42,7 +42,6 @@ module "eks_blueprints_addons" {
karpenter = {
repository_username = data.aws_ecrpublic_authorization_token.token.user_name
repository_password = data.aws_ecrpublic_authorization_token.token.password
version = "v0.36"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not used?

@bryantbiggs bryantbiggs merged commit db4ca4a into main Aug 12, 2024
4 of 5 checks passed
@bryantbiggs bryantbiggs deleted the fix/data_azs branch August 12, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants