Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update AWS provider to 'ecr' for ECR authentication #1992

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

edgarsilva948
Copy link
Contributor

Description

  • Updated AWS provider configuration to use alias 'ecr' and hardcode the region to 'us-east-1' for ECR authentication in patterns that use public ECR images and require authentication.

Motivation and Context

  • The intention is to keep the consistency in all repositories. This change ensures clear documentation and prevents users from mistakenly altering the region.

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [] Yes, I have updated the docs for this feature
  • [] Yes, I ran pre-commit run -a with this PR

Additional Notes

There is a provider here link with the old format, but it's not being used, so I didn't change it. Is it ok to update?

@edgarsilva948 edgarsilva948 requested a review from a team as a code owner August 6, 2024 05:50
@edgarsilva948 edgarsilva948 changed the title chore: update AWS provider to 'ecr' for ECR authentication chore: Update AWS provider to 'ecr' for ECR authentication Aug 6, 2024
@bryantbiggs bryantbiggs merged commit 5d45b07 into aws-ia:main Aug 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants