Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add pattern that demonstrates using ML capacity block reservation with self-managed node group #1941

Merged
merged 1 commit into from
May 8, 2024
Merged

feat: Add pattern that demonstrates using ML capacity block reservation with self-managed node group #1941

merged 1 commit into from
May 8, 2024

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Add pattern that demonstrates using ML capacity block reservation with self-managed node group

Motivation and Context

  • Demonstrate how customers can use CBRs with EKS today; will update at later day to use EKS managed node group when that support is added to the service

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

In draft mode pending terraform-aws-modules/terraform-aws-eks#3030

askulkarni2
askulkarni2 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@bryantbiggs bryantbiggs marked this pull request as ready for review May 8, 2024 12:40
@bryantbiggs bryantbiggs requested a review from a team as a code owner May 8, 2024 12:40
@bryantbiggs bryantbiggs merged commit 447cb5f into main May 8, 2024
5 checks passed
@bryantbiggs bryantbiggs deleted the feat/ml-capacity-blocks branch May 8, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @askulkarni2