Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update in Custom Networking for vpc-cni instructions #1935

Closed
wants to merge 8 commits into from

Conversation

herrerasm
Copy link

@herrerasm herrerasm commented Apr 27, 2024

Description

PR includes additional information on the provider for the custom resource for kubectl_manifest, the IRSA role needed and additional clarifications for private clusters.

Motivation and Context

  • Resolves #
    After working with the blueprints, I was not able to make work the custom networking only using the documentation and had to do further research that took longer than expected.

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR
  • Change in documentation, not in implementation

Additional Notes

@herrerasm herrerasm requested a review from a team as a code owner April 27, 2024 12:10
@herrerasm herrerasm changed the title Change in Custom Networking for vpc-cni documentation docs: Update in Custom Networking for vpc-cni instructions Apr 30, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jun 20, 2024
Copy link
Contributor

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants