Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve sso output #1931

Merged
merged 1 commit into from
Apr 24, 2024
Merged

chore: Improve sso output #1931

merged 1 commit into from
Apr 24, 2024

Conversation

allamand
Copy link
Contributor

Description

Motivation and Context

It was hard at a first hand to understand what was going wrong and how to use the pattern.

This small improvment makes clearer what needs to be checked

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@allamand allamand requested a review from a team as a code owner April 24, 2024 16:52
@askulkarni2 askulkarni2 changed the title improve sso output chore: Improve sso output Apr 24, 2024
askulkarni2
askulkarni2 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

@askulkarni2 askulkarni2 merged commit f7ed1ea into main Apr 24, 2024
5 of 6 checks passed
@askulkarni2 askulkarni2 deleted the sso-pattern branch April 24, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allamand @askulkarni2