Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pattern that demonstrates how to consume targeted ODCRs #1922

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Add pattern that demonstrates how to consume targeted ODCRs

Motivation and Context

  • Provide example guidance on how to integrate ODCR consumption into EKS

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner April 18, 2024 17:18
@@ -0,0 +1,21 @@
import os
Copy link
Contributor Author

@bryantbiggs bryantbiggs Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is how the supporting assets (i.e. - images) for a pattern are copied over into the built doc site. If you see the current Kubecost pattern, it shows the image in markdown on GitHub, but not on the mkdoc site - I'll fix that after this PR using this code below

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the PR! :shipit:

@askulkarni2 askulkarni2 merged commit bbb1787 into main Apr 18, 2024
5 checks passed
@askulkarni2 askulkarni2 deleted the feat/targeted-odcr branch April 18, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants