Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update documentation for installing EFA device plugin to use official EKS chart #1904

Merged
merged 2 commits into from
Mar 13, 2024
Merged

chore: Update documentation for installing EFA device plugin to use official EKS chart #1904

merged 2 commits into from
Mar 13, 2024

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Update documentation for installing EFA device plugin to use official EKS chart
  • Replace use of GPU operator with NVIDIA K8s device plugin
  • Update EKS module version to use EFA enablement features

Motivation and Context

Ref: aws-neuron/aws-neuron-sdk#850
Ref: aws-samples/aws-efa-eks#22 (comment)
Ref: awsdocs/amazon-eks-user-guide#747

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner March 13, 2024 21:32
askulkarni2
askulkarni2 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor(optional) comment.

patterns/elastic-fabric-adapter/README.md Outdated Show resolved Hide resolved
@bryantbiggs @askulkarni2
Update README.md
2e391cc 
Co-authored-by: Apoorva Kulkarni <[email protected]>
@bryantbiggs bryantbiggs merged commit d5c9253 into main Mar 13, 2024
5 checks passed
@bryantbiggs bryantbiggs deleted the chore/update-k8s-efa-install branch March 13, 2024 22:03
@bryantbiggs bryantbiggs mentioned this pull request Mar 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @askulkarni2