fix: Pattern-blue-green-upgrade update example for tfvars
#1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allamand
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
|
Thanks for the PR @allamand |
bryantbiggs
reviewed
Nov 1, 2023
| @@ -1,5 +1,5 @@ | |||
| terraform { | |||
| required_version = ">= 1.0" | |||
| required_version = ">= 1.4.0" | |||
There was a problem hiding this comment.
are we using any features that require a MSV of 1.4?
There was a problem hiding this comment.
no, we have recommendation of version on this ?
There was a problem hiding this comment.
the required version should be the minimum supported version - so unless we are using a feature thats only available starting with Terraform 1.4, then we default to 1.0
rodrigobersa
changed the title
tfvars
rodrigobersa
changed the title
tfvarstfvars
bryantbiggs
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The example tfvars was not using the right source for gitops bridge
How was this change tested?
pre-commit run -awith this PRAdditional Notes