Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Added additional info to README.md of Istio example #1745

Merged
merged 1 commit into from
Sep 5, 2023
Merged

docs: Added additional info to README.md of Istio example #1745

merged 1 commit into from
Sep 5, 2023

Conversation

tiagoReichert
Copy link
Contributor

@tiagoReichert tiagoReichert commented Sep 5, 2023 •
edited
Loading

Description

Motivation and Context

  • Resolves #

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@tiagoReichert tiagoReichert requested a review from a team as a code owner September 5, 2023 01:12
@tiagoReichert tiagoReichert temporarily deployed to EKS Blueprints Test September 5, 2023 01:12 — with GitHub Actions Inactive
praseedasathaye
praseedasathaye reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@praseedasathaye praseedasathaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please help approve this.

@askulkarni2 askulkarni2 changed the title Added additional info to README.md of Istio example docs: Added additional info to README.md of Istio example Sep 5, 2023
askulkarni2
askulkarni2 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@askulkarni2 askulkarni2 merged commit 1e3bc5b into aws-ia:main Sep 5, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praseedasathaye praseedasathaye praseedasathaye left review comments

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiagoReichert @askulkarni2 @praseedasathaye