Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Update examples to use new addons module repo; remove module implementations #1494

Merged
merged 36 commits into from
Jun 5, 2023
Merged

feat!: Update examples to use new addons module repo; remove module implementations #1494

merged 36 commits into from
Jun 5, 2023

Conversation

askulkarni2
Copy link
Contributor

@askulkarni2 askulkarni2 commented Mar 14, 2023 •
edited by bryantbiggs
Loading

What does this PR do?

  • Updates examples to use the new https://github.com/aws-ia/terraform-aws-eks-blueprints-addons repo for addons.
  • Replaces decommissioned add-ons with examples that show use of the helm_release resource or https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/eks-blueprints-addon helper module in-cases where IRSA would be needed (e.g. appmesh-controller)
  • Removes module implementations; further migration documentation from EKS Blueprints to recommended modules will follow shortly

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 requested a review from a team as a code owner March 14, 2023 21:08
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test March 14, 2023 21:08 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 changed the title Refactor/addons module refactor: Update examples to use new addons module repo Mar 14, 2023
@askulkarni2 askulkarni2 marked this pull request as draft March 14, 2023 21:14
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test March 17, 2023 22:54 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test March 17, 2023 23:05 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test March 17, 2023 23:07 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test March 18, 2023 01:45 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test March 20, 2023 17:40 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test March 20, 2023 18:07 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test March 20, 2023 19:02 — with GitHub Actions Inactive
@askulkarni2 askulkarni2 marked this pull request as ready for review March 20, 2023 20:04
@csantanapr
feat: Test ipv6 example (#1584)
10ee0fd 
Update ipv6 example
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test May 25, 2023 23:18 — with GitHub Actions Inactive
@rodrigobersa rodrigobersa temporarily deployed to EKS Blueprints Test June 3, 2023 15:17 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs changed the title refactor: Update examples to use new addons module repo feat!: Update examples to use new addons module repo; remove module implementations Jun 5, 2023
@bryantbiggs bryantbiggs merged commit 19c7cfd into main Jun 5, 2023
@bryantbiggs bryantbiggs deleted the refactor/addons-module branch June 5, 2023 14:07
@bryantbiggs bryantbiggs mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@askulkarni2 @rodrigobersa @bryantbiggs @fcarta29 @csantanapr @candonov @allamand