Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update examples to use terraform-aws-eks module where possible #1428

Merged
merged 10 commits into from
Feb 14, 2023
Merged

chore: Update examples to use terraform-aws-eks module where possible #1428

merged 10 commits into from
Feb 14, 2023

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Feb 11, 2023 •
edited
Loading

What does this PR do?

  • Update examples to use terraform-aws-eks module where possible
  • Remove examples that have moved to data on EKS
    • ai-ml/ray
    • analytics/emr-eks-fsx-lustre
    • analytics/emr-on-eks
  • Remove redundant examples; those that simply show enabling an addon but are not part of a larger architectural pattern
    • complete-kubernetes-addons
    • crossplane (empty)
    • eks-cluster-with-external-dns (blue/green upgrade shows external-dns)
    • eks-cluster-with-new-vpc
    • grafana-loki
    • secrets-management/csi-secrets-driver
  • Remove node group examples since node groups will be removed in v5

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner February 11, 2023 01:58
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test February 11, 2023 01:58 — with GitHub Actions Inactive
@bryantbiggs
Copy link
Contributor Author

any examples that have moved (raised to root of examples/ directory) or have been removed will show as a fail on the CI checks - this is to be expectdd

askulkarni2
askulkarni2 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test February 13, 2023 16:51 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test February 13, 2023 17:19 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test February 13, 2023 17:39 — with GitHub Actions Inactive
@Zvikan Zvikan temporarily deployed to EKS Blueprints Test February 13, 2023 18:03 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test February 13, 2023 18:54 — with GitHub Actions Inactive
@Zvikan Zvikan temporarily deployed to EKS Blueprints Test February 13, 2023 19:39 — with GitHub Actions Inactive
@Zvikan Zvikan temporarily deployed to EKS Blueprints Test February 13, 2023 19:43 — with GitHub Actions Inactive
@Zvikan Zvikan temporarily deployed to EKS Blueprints Test February 13, 2023 20:18 — with GitHub Actions Inactive
vara-bonthu
vara-bonthu requested changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emr-eks-fargate example can be removed as well from this repo. I have raised a PR to move this pattern to Data on EKS.

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test February 13, 2023 23:46 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test February 14, 2023 00:25 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs merged commit 243ae23 into main Feb 14, 2023
@bryantbiggs bryantbiggs deleted the chore/update-examples branch February 14, 2023 21:25
@Tstrul-work Tstrul-work mentioned this pull request Feb 21, 2023
Closed
kbumsik added a commit to kbumsik/terraform-aws-eks-blueprints that referenced this pull request Feb 27, 2023
@kbumsik
doc(.pages): Remove empty "Node Groups" section
5a5ab5c 
As part of v5 migration, aws-ia#1428
removes "Node Groups" page, but forgot to remove the page button.

This commit removes the "Node Groups" button in the documentation page.
kbumsik added a commit to kbumsik/terraform-aws-eks-blueprints that referenced this pull request Feb 27, 2023
@kbumsik
doc: Mention terraform-aws-modules in cluster explanation.
94739fc 
As part of v5 migration, aws-ia#1428
removes "Node Groups" page.

As a result, new users likely lost what to do when configuring a cluster.

We at least need to mention that we use `terraform-aws-modules/eks/aws`
to avoid confusion.
@kbumsik kbumsik mentioned this pull request Feb 27, 2023
Merged
4 tasks
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request Mar 17, 2023
@bryantbiggs @Zvikan
chore: Update examples to use terraform-aws-eks module where possib…
1f9e278 
…le (aws-ia#1428)

Co-authored-by: Zvikan <[email protected]>
@MarcAnProv MarcAnProv mentioned this pull request May 3, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

@vara-bonthu vara-bonthu vara-bonthu approved these changes

@Zvikan Zvikan Zvikan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bryantbiggs @askulkarni2 @vara-bonthu @Zvikan