Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make pubsub topic configurable #12

Merged
merged 1 commit into from
Mar 27, 2024
Merged

feat: make pubsub topic configurable #12

merged 1 commit into from
Mar 27, 2024

Conversation

MikeDombo
Copy link
Member

Issue #, if available:
Closes #10

Description of changes:

Resolves #10 by making the pubsub topic configurable just like the MQTT topic is configurable.

Why is this change necessary:

How was this change tested:

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

Unit Tests Coverage Report

File Coverage Lines Branches
All files 98% 99% 97%
com.aws.greengrass.telemetry.nucleus.emitter.publisher.PubSubPublisher 100% 100% 0%
com.aws.greengrass.telemetry.nucleus.emitter.publisher.MqttPublisher 100% 100% 100%
com.aws.greengrass.telemetry.nucleus.emitter.metrics.PeriodicMetricsEmitter 100% 100% 0%
com.aws.greengrass.telemetry.nucleus.emitter.metrics.SystemMetricsEmitter 100% 100% 0%
com.aws.greengrass.telemetry.nucleus.emitter.metrics.KernelMetricsEmitter 100% 100% 100%
com.aws.greengrass.telemetry.nucleus.emitter.NucleusEmitter 98% 100% 97%
com.aws.greengrass.telemetry.nucleus.emitter.NucleusEmitterConfiguration 95% 95% 96%
com.aws.greengrass.telemetry.nucleus.emitter.Constants 0% 0% 0%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7602a06

@MikeDombo MikeDombo merged commit 0102547 into main Mar 27, 2024
2 checks passed
@MikeDombo MikeDombo deleted the config-topic branch March 27, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include thing name in the message
3 participants