fix: mark run as done when skipif is true #1672
Draft
+117
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently, when
skipif
evaluates totrue
,RunStatus
is set toOK
in the result. But,RunStatus.OK
is currently not handled in by the Run handler. We could either add a case to handleOK
or mark the skipifRunStatus
toNothingDone
.This doesn't impact INSTALL lifecycle as it only cares when
RunStatus
isErrored
.aws-greengrass-nucleus/src/main/java/com/aws/greengrass/lifecyclemanager/GenericExternalService.java
Lines 523 to 538 in fa01ab3
Run lifecyle doesn't handle
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.