fix: check for 0 subscription batches #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
integration/src/main/java/com/aws/greengrass/mqtt/moquette/MQTTService.java
Dismissed
Show dismissed
Hide dismissed
integration/src/main/java/com/aws/greengrass/mqtt/moquette/MQTTService.java
Dismissed
Show dismissed
Hide dismissed
integration/src/main/java/com/aws/greengrass/mqtt/moquette/MQTTService.java
Dismissed
Show dismissed
Hide dismissed
integration/src/main/java/com/aws/greengrass/mqtt/moquette/MQTTService.java
Dismissed
Show dismissed
Hide dismissed
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against e5ef659 |
jcosentino11
approved these changes
Sep 14, 2023
ravimud
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Updates our reference to moquette constants to use the non-deprecated consts. Disables persistence.
Attempt to fix moquette-io/moquette#750 which I just saw in our pipeline.
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.