Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: disconnect client on authZ failure #116

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

MikeDombo
Copy link
Member

Issue #, if available:

Description of changes:
Disconnect clients on authZ failure for publish qos1 or qos 0. This way they are forced to reauthenticate.

Why is this change necessary:

How was this change tested:

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Unit Tests Coverage Report

File Coverage Lines Branches
All files 70% 76% 63%
com.aws.greengrass.mqtt.moquette.GreengrassMoquetteSslContextCreator 51% 60% 41%
com.aws.greengrass.mqtt.moquette.ClientDeviceAuthorizer 86% 84% 88%
com.aws.greengrass.mqtt.moquette.ClientDeviceTrustManager 95% 90% 100%
com.aws.greengrass.mqtt.moquette.BrokerKeyStore 64% 64% 0%
com.aws.greengrass.mqtt.moquette.MQTTService 77% 83% 71%
com.aws.greengrass.mqtt.moquette.ClientDeviceAuthorizer$ConnectionTerminationListener 67% 85% 50%
com.aws.greengrass.mqtt.moquette.ClientDeviceAuthorizer$UserSessionPair 100% 100% 0%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 9a9f834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants