Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uat 2 #216

Closed
wants to merge 2 commits into from
Closed

Uat 2 #216

wants to merge 2 commits into from

Conversation

MikeDombo
Copy link
Member

Issue #, if available:

Description of changes:

Why is this change necessary:

How was this change tested:

Any additional information or context required to review the change:

Checklist:

  • Updated the README if applicable
  • Updated or added new unit tests
  • Updated or added new integration tests
  • Updated or added new end-to-end tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad0abce) 84.79% compared to head (bcd235e) 85.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   84.79%   85.64%   +0.85%     
==========================================
  Files          13       13              
  Lines        1052     1052              
  Branches      109      109              
==========================================
+ Hits          892      901       +9     
+ Misses        100       93       -7     
+ Partials       60       58       -2     
Flag Coverage Δ
integration 68.25% <ø> (-0.48%) ⬇️
unit 85.64% <ø> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Unit Tests Coverage Report

File Coverage Lines Branches
All files 77% 84% 71%
com.aws.greengrass.logmanager.services.DiskSpaceManagementService 71% 83% 60%
com.aws.greengrass.logmanager.CloudWatchLogsUploader 90% 97% 83%
com.aws.greengrass.logmanager.LogManagerService 69% 81% 56%
com.aws.greengrass.logmanager.LogManagerService$CurrentProcessingFileInformation 79% 89% 68%
com.aws.greengrass.logmanager.PositionTrackingBufferedReader 86% 87% 86%
com.aws.greengrass.logmanager.CloudWatchAttemptLogsProcessor 88% 89% 86%
com.aws.greengrass.logmanager.util.ConfigUtil 85% 85% 85%
com.aws.greengrass.logmanager.util.CloudWatchClientFactory 53% 53% 0%
com.aws.greengrass.logmanager.model.CloudWatchAttemptLogInformation 100% 100% 0%
com.aws.greengrass.logmanager.model.EventType 100% 100% 0%
com.aws.greengrass.logmanager.model.ComponentType 100% 100% 0%
com.aws.greengrass.logmanager.model.ProcessingFiles 65% 80% 50%
com.aws.greengrass.logmanager.model.LogFile 87% 82% 92%
com.aws.greengrass.logmanager.model.LogFileGroup 70% 75% 64%

Minimum allowed coverage is 65%

Generated by 🐒 cobertura-action against bcd235e

Copy link

Integration Tests Coverage Report

File Coverage Lines Branches
All files 67% 75% 58%
com.aws.greengrass.logmanager.services.DiskSpaceManagementService 47% 55% 40%
com.aws.greengrass.logmanager.CloudWatchLogsUploader 42% 42% 41%
com.aws.greengrass.logmanager.LogManagerService 81% 93% 70%
com.aws.greengrass.logmanager.LogManagerService$CurrentProcessingFileInformation 46% 55% 37%
com.aws.greengrass.logmanager.PositionTrackingBufferedReader 72% 82% 63%
com.aws.greengrass.logmanager.CloudWatchAttemptLogsProcessor 67% 73% 61%
com.aws.greengrass.logmanager.util.ConfigUtil 48% 61% 35%
com.aws.greengrass.logmanager.util.CloudWatchClientFactory 100% 100% 0%
com.aws.greengrass.logmanager.model.CloudWatchAttemptLogInformation 100% 100% 0%
com.aws.greengrass.logmanager.model.EventType 100% 100% 0%
com.aws.greengrass.logmanager.model.ComponentType 100% 100% 0%
com.aws.greengrass.logmanager.model.ProcessingFiles 76% 85% 68%
com.aws.greengrass.logmanager.model.LogFile 40% 46% 34%
com.aws.greengrass.logmanager.model.LogFileGroup 64% 74% 53%

Minimum allowed coverage is 58%

Generated by 🐒 cobertura-action against bcd235e

@MikeDombo MikeDombo closed this Nov 16, 2023
@MikeDombo MikeDombo deleted the uat-2 branch November 16, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant