feat: add thing attribute variable support #434
+935
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcosentino11
force-pushed
the
thing-attr-var-support
branch
from
6ec90c2
to
1fa6333
Compare
MikeDombo
reviewed
Jun 27, 2024
src/main/java/com/aws/greengrass/clientdevices/auth/iot/IotClientFactory.java
Outdated
Show resolved
Hide resolved
Benchmark Results
|
jcosentino11
force-pushed
the
thing-attr-var-support
branch
3 times, most recently
from
b54a027
to
84cc9ff
Compare
MikeDombo
reviewed
Jun 27, 2024
src/main/java/com/aws/greengrass/clientdevices/auth/iot/IotClientFactory.java
Outdated
Show resolved
Hide resolved
jcosentino11
force-pushed
the
thing-attr-var-support
branch
from
84cc9ff
to
fdfd350
Compare
|
Code Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3642a32 |
jcosentino11
force-pushed
the
thing-attr-var-support
branch
3 times, most recently
from
3749ce4
to
f974da4
Compare
jcosentino11
force-pushed
the
thing-attr-var-support
branch
from
f974da4
to
b4c43cd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/com/aws/greengrass/clientdevices/auth/configuration/RuntimeConfiguration.java
Fixed
Show fixed
Hide fixed
src/main/java/com/aws/greengrass/clientdevices/auth/configuration/RuntimeConfiguration.java
Fixed
Show fixed
Hide fixed
src/main/java/com/aws/greengrass/clientdevices/auth/configuration/RuntimeConfiguration.java
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#433
Description of changes:
Adds support for
${iot:Connection.Thing.Attributes[MyAttribute]}resource policy variables, similar to our existing${iot:Connection.Thing.ThingName}.Attributes are fetched from cloud on startup (and periodically) and are cached. Policy evaluation uses cached attributes.
TODO:
Why is this change necessary:
How was this change tested:
Integration tests, UATs to follow to actually test cloud interactions.
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.